Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030408AbVIVPiE (ORCPT ); Thu, 22 Sep 2005 11:38:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030407AbVIVPiE (ORCPT ); Thu, 22 Sep 2005 11:38:04 -0400 Received: from omx1-ext.sgi.com ([192.48.179.11]:42695 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1030408AbVIVPiC (ORCPT ); Thu, 22 Sep 2005 11:38:02 -0400 Date: Thu, 22 Sep 2005 08:37:36 -0700 (PDT) From: Christoph Lameter To: Andi Kleen cc: Christoph Hellwig , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netfilter-devel@lists.netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH 0/3] netfilter : 3 patches to boost ip_tables performance In-Reply-To: <200509221505.05395.ak@suse.de> Message-ID: References: <43308324.70403@cosmosbay.com> <200509221454.22923.ak@suse.de> <20050922125849.GA27413@infradead.org> <200509221505.05395.ak@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 20 On Thu, 22 Sep 2005, Andi Kleen wrote: > On Thursday 22 September 2005 14:58, Christoph Hellwig wrote: > > > Umm, no - adding set_fs/get_fs mess for things like that is not right. > > I think it's fine. We're using it for various other interfaces too. In fact > sys_set_mempolicy is already used elsewhere in the kernel too. It should really be do_set_mempolicy instead to be cleaner. I got a patch here that fixes the policy layer. But still I agree with Christoph that a real vmalloc_node is better. There will be no fuzzing around with memory policies etc and its certainly better performance wise. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/