Date: Fri, 23 Sep 2005 00:40:31 -0700
From: Andrew Morton <akpm@osdl.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: blaisorblade@yahoo.it, user-mode-linux-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] [PATCH 06/10] uml: run mconsole "sysrq" in process
 context
Message-Id: <20050923004031.6b7da42a.akpm@osdl.org>
In-Reply-To: <20050922203743.GA11648@ccure.user-mode-linux.org>
References: <200509211923.21861.blaisorblade@yahoo.it>
	<20050921172857.10219.71071.stgit@zion.home.lan>
	<20050921205028.GB9918@ccure.user-mode-linux.org>
	<200509222120.20922.blaisorblade@yahoo.it>
	<20050922203743.GA11648@ccure.user-mode-linux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1090
Lines: 29

Jeff Dike <jdike@addtoit.com> wrote:
>
> On Thu, Sep 22, 2005 at 09:20:20PM +0200, Blaisorblade wrote:
> > sysrq t is broken (and stays), 
> 
> There's a fix on the way for that.  This has nothing to do with interrupt
> context anyway.
> 
> > but additionally there are some warnings from 
> > some commands (enable sleep inside spinlock checking and spinlock debugging), 
> > which go to the down_read inside handle_page_fault IIRC. So try to run in 
> > process context.
> 
> Which ones?  They should be fixed.
> 
> It is fairly fundamental to sysrq that it work from interrupt context.  You
> may be diagnosing a system which can't context switch any more.
> 
> This patch should be dropped, and the real problems fixed.
> 

Well Linus has just merged this patch.  If you hadn't removed me from the
cc yesterday this would not have happened.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/