Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751122AbVIWSYW (ORCPT ); Fri, 23 Sep 2005 14:24:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751128AbVIWSYW (ORCPT ); Fri, 23 Sep 2005 14:24:22 -0400 Received: from zproxy.gmail.com ([64.233.162.192]:50035 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S1751122AbVIWSYV convert rfc822-to-8bit (ORCPT ); Fri, 23 Sep 2005 14:24:21 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RiNvMiIkNbF5zILcPp7mz0zbXTCI9PBAIFXQYdSf9zQC/zHSD2BbI5ninFVLuTmGehGKLJsRy/KuzMqs1TduT2AGYUhiGNCoivwHBFm8EXngOlZTLjj2a156gjTAqIt8HsvPKqMnWQ/ruirzeRDJaFmJWYiwE3lQexXL1yODMLw= Message-ID: <29495f1d05092311244895d723@mail.gmail.com> Date: Fri, 23 Sep 2005 11:24:19 -0700 From: Nish Aravamudan Reply-To: Nish Aravamudan To: Davide Libenzi Subject: Re: [patch] sys_epoll_wait() timeout saga ... Cc: Linux Kernel Mailing List , Andrew Morton In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 24 On 9/23/05, Davide Libenzi wrote: > > The sys_epoll_wait() function was not handling correctly negative timeouts > (besides -1), and like sys_poll(), was comparing millisec to secs in > testing the upper timeout limit. > > > Signed-off-by: Davide Libenzi Looks a lot more correct :) Probably want to eventually convert the code path to be similar to sys_poll(), though? Maybe with a helper to do the converting? I think the epoll code can probable use msecs_to_jiffies() + 1 as well, no? I will wait for your patch to go in and send a patch for these ideas later. Thanks, Nish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/