Date: Fri, 23 Sep 2005 16:57:29 -0700 (PDT)
From: Christoph Lameter <clameter@engr.sgi.com>
To: Alok Kataria <alokk@calsoftinc.com>
cc: Petr Vandrovec <vandrove@vc.cvut.cz>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org, manfred@colorfullife.com
Subject: Re: 2.6.14-rc1-git-now still dying in mm/slab - this time line 1849
In-Reply-To: <433458B6.7000008@calsoftinc.com>
Message-ID: <Pine.LNX.4.62.0509231648090.25804@schroedinger.engr.sgi.com>
References: <433458B6.7000008@calsoftinc.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1190
Lines: 30

On Sat, 24 Sep 2005, Alok Kataria wrote:

> But the nodeid is already accessible through the slab-descriptor of this
> object, and this nodeid is set in the cache_grow
> function.

Correct. We still have no explanation why the slab was later assigned to 
the wrong node. The patch fixes the locking issue though because the wrong 
nodeid field is now ignored. There is certianly more to fix here.

> > /Also removes the check for the current node from kmalloc_cache_node since
> > the
> > process may shift later to another node which may lead to an allocation on
> > another
> > node than intended.
> > /
> > 
> Yeah that is possible, but won't putting a check in __cache_alloc_node after
> disabling the interrupt be better, because kmalloc_node/kmem_cache_alloc_node
> can be called at runtime as well, and getting the object directly from the
> slabs, instead of the arraycaches may slow up things.
> Thus tweaking the patch a little.

Good

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/