Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932430AbVIZInK (ORCPT ); Mon, 26 Sep 2005 04:43:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932433AbVIZInK (ORCPT ); Mon, 26 Sep 2005 04:43:10 -0400 Received: from silver.veritas.com ([143.127.12.111]:5693 "EHLO silver.veritas.com") by vger.kernel.org with ESMTP id S932430AbVIZInJ (ORCPT ); Mon, 26 Sep 2005 04:43:09 -0400 Date: Mon, 26 Sep 2005 09:42:34 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@goblin.wat.veritas.com To: Nick Piggin cc: Andrew Morton , lkml Subject: Re: [PATCH 17/21] mm: batch updating mm_counters In-Reply-To: <1127719503.5101.38.camel@npiggin-nld.site> Message-ID: References: <1127719503.5101.38.camel@npiggin-nld.site> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 26 Sep 2005 08:43:03.0514 (UTC) FILETIME=[4EDFB3A0:01C5C276] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 24 On Mon, 26 Sep 2005, Nick Piggin wrote: > On Sun, 2005-09-25 at 17:08 +0100, Hugh Dickins wrote: > > - copy_one_pte(dst_mm, src_mm, dst_pte, src_pte, vm_flags, addr); > > + anon = copy_one_pte(dst_mm, src_mm, dst_pte, src_pte, > > + vm_flags, addr); > > + rss[anon]++; > > How about passing rss[2] to copy_one_pte, and have that > increment the correct rss value accordingly? Not that > you may consider that any nicer than what you have here. That does seem a more _normal_ way of doing it. Though adding a seventh argument doesn't appeal (perhaps irrelevant since copy_one_pte is inlined). I don't mind much either way: anyone have strong feelings? Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/