Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932453AbVIZSKr (ORCPT ); Mon, 26 Sep 2005 14:10:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932454AbVIZSKr (ORCPT ); Mon, 26 Sep 2005 14:10:47 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:41964 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S932453AbVIZSKq (ORCPT ); Mon, 26 Sep 2005 14:10:46 -0400 Subject: Re: vmalloc_node From: Dave Hansen To: Christoph Lameter Cc: Eric Dumazet , Harald Welte , Andi Kleen , Andrew Morton , Christoph Hellwig , "David S. Miller" , Linux Kernel Mailing List In-Reply-To: References: <43308324.70403@cosmosbay.com> <200509221454.22923.ak@suse.de> <20050922125849.GA27413@infradead.org> <200509221505.05395.ak@suse.de> <4332D2D9.7090802@cosmosbay.com> <20050923171120.GO731@sunbeam.de.gnumonks.org> <1127498679.10664.85.camel@localhost> Content-Type: text/plain Date: Mon, 26 Sep 2005 11:10:13 -0700 Message-Id: <1127758214.26894.20.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 28 On Mon, 2005-09-26 at 10:58 -0700, Christoph Lameter wrote: > On Fri, 23 Sep 2005, Dave Hansen wrote: > > Instead of hard-coding all of those -1's for the node to specify a > > default allocation, and changing all of those callers, why not: > > Done. That looks much nicer. Thanks! > > __vmalloc_node(size, gfp_mask, prot, -1); > > A named macro is probably better than -1, but if it is only used in one > > place, it is hard to complain. > > -1 is used consistently in the *_node functions to indicate that the node > is not specified. Should I replace -1 throughout the kernel with a > constant? I certainly wouldn't mind. Giving it a name like NODE_ANY or NODE_UNSPECIFIED would certainly keep anyone from having to go dig into the allocator functions to decide what it actually does. -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/