Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932350AbVIZW3M (ORCPT ); Mon, 26 Sep 2005 18:29:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932493AbVIZW3L (ORCPT ); Mon, 26 Sep 2005 18:29:11 -0400 Received: from mail.avalus.com ([195.82.114.197]:24754 "EHLO shed.alex.org.uk") by vger.kernel.org with ESMTP id S932350AbVIZW3K (ORCPT ); Mon, 26 Sep 2005 18:29:10 -0400 Date: Mon, 26 Sep 2005 23:29:01 +0100 From: Alex Bligh - linux-kernel Reply-To: Alex Bligh - linux-kernel To: Joel Schopp , Andrew Morton Cc: Joel Schopp , lhms , Linux Memory Management List , linux-kernel@vger.kernel.org, Mel Gorman , Mike Kravetz , Alex Bligh - linux-kernel Subject: Re: [PATCH 4/9] defrag helper functions Message-ID: In-Reply-To: <43385594.3080303@austin.ibm.com> References: <4338537E.8070603@austin.ibm.com> <43385594.3080303@austin.ibm.com> X-Mailer: Mulberry/4.0.3 (Win32) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 29 --On 26 September 2005 15:09 -0500 Joel Schopp wrote: > +void assign_bit(int bit_nr, unsigned long* map, int value) Maybe: static inline void assign_bit(int bit_nr, unsigned long* map, int value) it's short enough > +static struct page * > +fallback_alloc(int alloctype, struct zone *zone, unsigned int order) > +{ > + /* Stub out for seperate review, NULL equates to no fallback*/ > + return NULL; > + > +} Maybe "static inline" too. -- Alex Bligh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/