Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964827AbVI0GNF (ORCPT ); Tue, 27 Sep 2005 02:13:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964828AbVI0GNF (ORCPT ); Tue, 27 Sep 2005 02:13:05 -0400 Received: from mail.renesas.com ([202.234.163.13]:39156 "EHLO mail01.idc.renesas.com") by vger.kernel.org with ESMTP id S964827AbVI0GNE (ORCPT ); Tue, 27 Sep 2005 02:13:04 -0400 Date: Tue, 27 Sep 2005 15:13:01 +0900 (JST) Message-Id: <20050927.151301.189720995.takata.hirokazu@renesas.com> To: viro@ftp.linux.org.uk Cc: torvalds@odsl.org, linux-kernel@vger.kernel.org, takata@linux-m32r.org Subject: Re: [PATCH] m32r: set CHECKFLAGS properly From: Hirokazu Takata In-Reply-To: References: X-Mailer: Mew version 3.3 on XEmacs 21.4.17 (Jumbo Shrimp) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 46 Please don't specify __BIG_ENDIAN__. ;-) We have supported both big- and little-endian for the m32r kernel. I hope it will be kept unconditional. Now, the endianness is to be determined by a (cross)compiler: - For the big-endian, a compiler (m32r-linux-gcc or m32r-linux-gnu-gcc) provides a predefined macro __BIG_ENDIAN__. - For little-endian, a compiler (m32rle-linux-gcc or m32rle-linux-gnu-gcc) provides a predefined macro __LITTLE_ENDIAN__. Here is a modified patch. Thank you. From: Al Viro Date: Mon, 26 Sep 2005 06:18:04 +0100 > What we do need is __BIG_ENDIAN__; right now unconditional, when m32r starts > using CPU_LITTLE_ENDIAN, we'll need to adjust. Signed-off-by: Al Viro Signed-off-by: Hirokazu Takata ---- arch/m32r/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.14-rc2/arch/m32r/Makefile =================================================================== --- linux-2.6.14-rc2.orig/arch/m32r/Makefile 2005-08-29 08:41:01.000000000 +0900 +++ linux-2.6.14-rc2/arch/m32r/Makefile 2005-09-27 13:15:19.000000000 +0900 @@ -24,7 +24,7 @@ aflags-$(CONFIG_ISA_M32R) += -DNO_FPU -W CFLAGS += $(cflags-y) AFLAGS += $(aflags-y) -CHECKFLAGS := $(CHECK) -D__m32r__ +CHECKFLAGS += -D__m32r__ head-y := arch/m32r/kernel/head.o arch/m32r/kernel/init_task.o -- Hirokazu Takata Linux/M32R Project: http://www.linux-m32r.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/