Date: Tue, 27 Sep 2005 02:13:37 -0700
From: Greg KH <greg@kroah.com>
To: Harald Welte <laforge@gnumonks.org>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       vendor-sec@lst.de, security@linux.kernel.org
Subject: Re: [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
Message-ID: <20050927091337.GA9117@kroah.com>
References: <20050925151330.GL731@sunbeam.de.gnumonks.org> <20050927080413.GA13149@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050927080413.GA13149@kroah.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1209
Lines: 30

On Tue, Sep 27, 2005 at 01:04:15AM -0700, Greg KH wrote:
> First off, thanks for providing a patch for this problem, it is real,
> and has been known for a while (thanks to your debugging :)
> 
> On Sun, Sep 25, 2005 at 05:13:30PM +0200, Harald Welte wrote:
> > 
> > I suggest this (or any other) fix to be applied to both 2.6.14 final and
> > the stable series.  I didn't yet investigate 2.4.x, but I think it is
> > likely to have the same problem.
> 
> I agree, but I think we need an EXPORT_SYMBOL_GPL() for your newly
> exported symbol, otherwise the kernel will not build if you have USB
> built as a module.

Hm, it's even messier.  With your patch, we get:
	*** Warning: "__send_sig_info" [drivers/usb/core/usbcore.ko] undefined!
	*** Warning: "__put_task_struct" [drivers/usb/core/usbcore.ko] undefined!
when the USB core is a module.

I can't pass judgement if we want to export both of these functions to
modules...  Anyone else know?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/