Date: Wed, 28 Sep 2005 15:35:01 +0900
From: KUROSAWA Takahiro <kurosawa@valinux.co.jp>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: pj@sgi.com, taka@valinux.co.jp, magnus.damm@gmail.com, dino@in.ibm.com,
       linux-kernel@vger.kernel.org, ckrm-tech@lists.sourceforge.net
Subject: Re: [PATCH 1/3] CPUMETER: add cpumeter framework to the CPUSETS
In-Reply-To: <1127812937.5174.6.camel@npiggin-nld.site>
References: <20050908225539.0bc1acf6.pj@sgi.com>
	<20050909.203849.33293224.taka@valinux.co.jp>
	<20050909063131.64dc8155.pj@sgi.com>
	<20050910.161145.74742186.taka@valinux.co.jp>
	<20050910015209.4f581b8a.pj@sgi.com>
	<20050926093432.9975870043@sv1.valinux.co.jp>
	<20050927013751.47cbac8b.pj@sgi.com>
	<1127812937.5174.6.camel@npiggin-nld.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20050928063501.89B5A70041@sv1.valinux.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 25

On Tue, 27 Sep 2005 19:22:17 +1000
Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> It could have come a long way since then, but this code looks
> much neater than the code I reviewed.

I'm glad to hear that!  But the cpu resource controller has
some problems, for example:

- The controller only controls the time_slice value and doesn't
  care the balance of cpus (the controller leaves balancing to 
  the existing balancing code in the scheduler).  So far I don't
  have any good idea to solve this.

- The controller holds a spinlock once per 1 second.  I don't
  know this is permissive or not, but the current scheduler
  doesn't hold any spinlocks normally, so...

-- 
KUROSAWA, Takahiro
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/