Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750825AbVI1Rwt (ORCPT ); Wed, 28 Sep 2005 13:52:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750829AbVI1Rwt (ORCPT ); Wed, 28 Sep 2005 13:52:49 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:23698 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1750825AbVI1Rwt (ORCPT ); Wed, 28 Sep 2005 13:52:49 -0400 Date: Wed, 28 Sep 2005 18:52:44 +0100 From: Al Viro To: Borislav Petkov Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, R.E.Wolff@BitWizard.nl Subject: Re: [PATCH] remove check_region in drivers-char-specialix.c Message-ID: <20050928175244.GY7992@ftp.linux.org.uk> References: <20050928083737.GA29498@gollum.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050928083737.GA29498@gollum.tnic> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 668 Lines: 14 On Wed, Sep 28, 2005 at 10:37:37AM +0200, Borislav Petkov wrote: > Hi Andrew, > > This is also a pretty simple case. We remove the wrapper and make > sx__request_io_range return struct resource *. We check its value accordingly > in the probing routine. It compiles cleanly here. NAK. You've just introduced a pile of leaks - if sx_probe() fails after that call, you end up with region claimed and not released. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/