Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbVI2IL6 (ORCPT ); Thu, 29 Sep 2005 04:11:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751188AbVI2IL6 (ORCPT ); Thu, 29 Sep 2005 04:11:58 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:5534 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751125AbVI2IL4 (ORCPT ); Thu, 29 Sep 2005 04:11:56 -0400 Date: Thu, 29 Sep 2005 09:11:51 +0100 From: Christoph Hellwig To: Christoph Hellwig , Jeff Garzik , Joshua Kwan , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, axboe@suse.de, torvalds@osdl.org, randy_dunlap Subject: Re: SATA suspend/resume (was Re: [PATCH] updated version of Jens' SATA suspend-to-ram patch) Message-ID: <20050929081151.GA10660@infradead.org> Mail-Followup-To: Christoph Hellwig , Jeff Garzik , Joshua Kwan , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, axboe@suse.de, torvalds@osdl.org, randy_dunlap References: <20050923163334.GA13567@triplehelix.org> <433B79D8.9080305@pobox.com> <20050929073437.GC9669@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050929073437.GC9669@infradead.org> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 20 On Thu, Sep 29, 2005 at 08:34:37AM +0100, Christoph Hellwig wrote: > is an ULDD operation, not an LLDD one, and this fits the layering model > much better. The only complaints here are cosmetics: > > - generic_scsi_suspend/generic_scsi_resume are misnamed, they should > probably be scsi_device_suspend/resume. > - while we're at it they could probably move to scsi_sysfs.c to keep > them static in one file - they're just a tiny bit of glue anyway. > - get rid of all the CONFIG_PM ifdefs - it just clutters thing up far > too much. Actually one important thing is missing, that is a way to avoid spinning down external disks. As a start a sysfs-controlable flag should do it, later we can add transport-specific ways to find out whether a device is external. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/