Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964879AbVI2UBa (ORCPT ); Thu, 29 Sep 2005 16:01:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964884AbVI2UB3 (ORCPT ); Thu, 29 Sep 2005 16:01:29 -0400 Received: from smtp.osdl.org ([65.172.181.4]:14799 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964879AbVI2UB3 (ORCPT ); Thu, 29 Sep 2005 16:01:29 -0400 Date: Thu, 29 Sep 2005 13:00:18 -0700 (PDT) From: Linus Torvalds To: Deepak Saxena cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] Fix IXP4xx MTD driver no cast warning In-Reply-To: <20050929195205.GA30002@plexity.net> Message-ID: References: <20050929195205.GA30002@plexity.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 23 On Thu, 29 Sep 2005, Deepak Saxena wrote: > > drivers/mtd/maps/ixp4xx.c: In function 'ixp4xx_flash_probe': > drivers/mtd/maps/ixp4xx.c:199: warning: assignment makes integer from > pointer without a cast Please don't. The warning is entirely warranted, as far as I can tell. Shutting up warnings just because they are warnings is bad practice. Either fix them, or leave them be. If you do an "ioremap()", then the result is a "(void __iomem *)". If you assign it to something that is "unsigned long", you _should_ get a warning. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/