Date: Fri, 30 Sep 2005 06:48:18 +0100 (BST)
From: Hugh Dickins <hugh@veritas.com>
To: Chris Wright <chrisw@osdl.org>
cc: linux-kernel@vger.kernel.org, stable@kernel.org,
       Justin Forbes <jmforbes@linuxtx.org>,
       Zwane Mwaikambo <zwane@arm.linux.org.uk>,
       "Theodore Ts'o" <tytso@mit.edu>, Randy Dunlap <rdunlap@xenotime.net>,
       Chuck Wolber <chuckw@quantumlinux.com>, torvalds@osdl.org,
       akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
       "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 05/10] [PATCH]: Missing acct/mm calls in compat_do_execve()
In-Reply-To: <20050930022228.946664000@localhost.localdomain>
Message-ID: <Pine.LNX.4.61.0509300645530.7129@goblin.wat.veritas.com>
References: <20050930022016.640197000@localhost.localdomain>
 <20050930022228.946664000@localhost.localdomain>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 902
Lines: 23

On Thu, 29 Sep 2005, Chris Wright wrote:

> -stable review patch.  If anyone has any objections, please let us know.
> ------------------
> 
> As I do periodically, I checked to see how far out of sync
> compat_do_execve() has gotten from do_execve().  And as usual there
> was some missing stuff in the former.  Perhaps we need some tighter
> consolidation of these two routines to make this less likely to happen
> in the future.
> 
> Anyways, on the success path of compat_do_execve() we forget
> to call acct_update_integrals() and update_mem_hiwater(), as
> is done in do_execve().

The patch is good, but for -stable?  Spelling corrections next?

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/