Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932443AbVI3ILu (ORCPT ); Fri, 30 Sep 2005 04:11:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932572AbVI3ILt (ORCPT ); Fri, 30 Sep 2005 04:11:49 -0400 Received: from mail.parbin.co.uk ([213.162.111.43]:13195 "EHLO mail.parbin.co.uk") by vger.kernel.org with ESMTP id S932443AbVI3ILs (ORCPT ); Fri, 30 Sep 2005 04:11:48 -0400 Date: Fri, 30 Sep 2005 09:09:26 +0100 From: Alexander Clouter To: Blaisorblade Cc: LKML , cpufreq@lists.linux.org.uk, Andrew Morton , Dave Jones Subject: Re: [patch 1/1] cpufreq_conservative: invert meaning of 'ignore_nice' Message-ID: <20050930080926.GA3033@inskipp.digriz.org.uk> References: <20050929084435.GC3169@inskipp.digriz.org.uk> <200509291346.33855.blaisorblade@yahoo.it> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline In-Reply-To: <200509291346.33855.blaisorblade@yahoo.it> Organization: diGriz X-URL: http://www.digriz.org.uk/ User-Agent: Mutt/1.5.10i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2407 Lines: 82 --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Blaisorblade [20050929 13:46:33 +0200]: > > On Thursday 29 September 2005 10:44, Alexander Clouter wrote: >=20 > > WARNING: this obvious breaks any userland tools that expect things to be > > the other way round. This patch clears up the confusion but should go = in > > ASAP as at the moment it seems very few tools even make use of this > > functionality; all I could find was a Gentoo Wiki entry. >=20 > My suggestion on this is to rename the flag too, as ignore_nice_load (or= =20 > ignore_nice_tasks, choose your way). Don't forget to do it in docs too. >=20 'ignore_nice_tasks' gets my vote.. > So userspace tools will error out rather than do the reverse of what they= were=20 > doing, and the user will fix the thing according to the (new) docs. >=20 > This is the way we avoid problems in kernel code, when changing APIs (I r= ead=20 > Linus talking about this), so I assume it's ok? >=20 Makes a lot of sense. I'll roll out some new patches this evening and subm= it=20 them. Regards Alex > --=20 > Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". > Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 2156218= 94) > http://www.user-mode-linux.org/~blaisorblade >=20 >=20 > =09 >=20 > =09 > =09 > ___________________________________=20 > Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB=20 > http://mail.yahoo.it --=20 ________________________________________=20 < An idle mind is worth two in the bush. > ----------------------------------------=20 \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || || --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFDPPK2Nv5Ugh/sRBYRAlcYAJ0Z9R2BQu1tkJphBvjm2weFh3wjTwCgjgis sfKIC5ou8mMh4XlWM1fSAR4= =OK3Q -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/