Date: Mon, 3 Oct 2005 13:46:55 -0600
From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Adrian Bunk" <bunk@stusta.de>
cc: linux-kernel@vger.kernel.org
Subject: Re: AMD Geode GX/LX support
Message-ID: <20051003194655.GA30975@cosmic.amd.com>
References: <20051003174738.GC29264@cosmic.amd.com>
 <20051003180532.GE3652@stusta.de>
MIME-Version: 1.0
In-Reply-To: <20051003180532.GE3652@stusta.de>
User-Agent: Mutt/1.5.11
Content-Type: text/plain;
 charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1078
Lines: 34

> > +config MGEODE_GX
> > +	bool "Geode GX"
> > +	help
> > +	  Select this for AMD Geode GX processors.  Enables use of some extended
> > +	  instructions, and passes appropriate optimization flags to GCC.
> >...
> 
> The "and passes appropriate optimization flags to GCC" part seems to be 
> missing in your patches.

Yes - that is incorrect.  As you can no doubt see, I cut-n-pasted from
another processor.

> And it's not clear to me how your new MGEODE_GX option relates to the 
> already existing MGEODEGX1 option.

The already existing GEODEGX1 option as it stands has an invalid cache line
size, it should be 4 not 5.  I'll fix that up with the next revision of the 
patch.

Thanks for your comments,
Jordan

-- 
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/