Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964808AbVJDPe3 (ORCPT ); Tue, 4 Oct 2005 11:34:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964806AbVJDPe3 (ORCPT ); Tue, 4 Oct 2005 11:34:29 -0400 Received: from pollux.ds.pg.gda.pl ([153.19.208.7]:3338 "EHLO pollux.ds.pg.gda.pl") by vger.kernel.org with ESMTP id S964810AbVJDPe2 (ORCPT ); Tue, 4 Oct 2005 11:34:28 -0400 Date: Tue, 4 Oct 2005 16:34:35 +0100 (BST) From: "Maciej W. Rozycki" To: "Eric W. Biederman" Cc: Andrew Morton , linux-kernel@vger.kernel.org, fastboot@osdl.org Subject: Re: [PATCH] i386: move apic init in init_IRQs In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 587 Lines: 20 On Tue, 4 Oct 2005, Eric W. Biederman wrote: > - if (enable_local_apic < 0) > - clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability); I think this should stay. > + if (enable_local_apic < 0) { > + printk(KERN_INFO "Apic disabled\n"); Capitalisation. ;-) Otherwise it seems reasonable -- provided it works for you. ;-) Maciej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/