Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964822AbVJDPtd (ORCPT ); Tue, 4 Oct 2005 11:49:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964826AbVJDPtc (ORCPT ); Tue, 4 Oct 2005 11:49:32 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:25052 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S964822AbVJDPtc (ORCPT ); Tue, 4 Oct 2005 11:49:32 -0400 To: "Maciej W. Rozycki" Cc: Andrew Morton , linux-kernel@vger.kernel.org, fastboot@osdl.org Subject: Re: [PATCH] i386: move apic init in init_IRQs References: From: ebiederm@xmission.com (Eric W. Biederman) Date: Tue, 04 Oct 2005 09:48:01 -0600 In-Reply-To: (Maciej W. Rozycki's message of "Tue, 4 Oct 2005 16:34:35 +0100 (BST)") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 30 "Maciej W. Rozycki" writes: > On Tue, 4 Oct 2005, Eric W. Biederman wrote: > >> - if (enable_local_apic < 0) >> - clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability); > > I think this should stay. lapic_disable() already does this. I am just testing the results. >> + if (enable_local_apic < 0) { >> + printk(KERN_INFO "Apic disabled\n"); > > Capitalisation. ;-) > > Otherwise it seems reasonable -- provided it works for you. ;-) So what should the capitalization be? "APIC disabled\n" ? Sorry. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/