Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030215AbVJGOix (ORCPT ); Fri, 7 Oct 2005 10:38:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030218AbVJGOix (ORCPT ); Fri, 7 Oct 2005 10:38:53 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:56244 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1030215AbVJGOiw (ORCPT ); Fri, 7 Oct 2005 10:38:52 -0400 Date: Fri, 7 Oct 2005 15:38:50 +0100 From: Al Viro To: Miklos Szeredi Cc: akpm@osdl.org, trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfs: don't drop dentry in d_revalidate Message-ID: <20051007143850.GD7992@ftp.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 748 Lines: 17 On Fri, Oct 07, 2005 at 01:21:01PM +0200, Miklos Szeredi wrote: > NFS d_revalidate() is doing things that are supposed to be done by > d_invalidate(). > > Dropping the dentry is especially bad, since it will make > d_invalidate() bypass all checks. NAK. _IF_ you are going to start playing with that area, start with handling that stuff in caller before going after methods. Note that the only relatively sane semantics is to have equivalent on umount -l done to everything that becomes unreachable. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/