Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030319AbVJGPOK (ORCPT ); Fri, 7 Oct 2005 11:14:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030330AbVJGPOJ (ORCPT ); Fri, 7 Oct 2005 11:14:09 -0400 Received: from pat.uio.no ([129.240.130.16]:24222 "EHLO pat.uio.no") by vger.kernel.org with ESMTP id S1030319AbVJGPOH (ORCPT ); Fri, 7 Oct 2005 11:14:07 -0400 Subject: Re: [RFC] atomic create+open From: Trond Myklebust To: Miklos Szeredi Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org In-Reply-To: References: <1128616864.8396.32.camel@lade.trondhjem.org> <1128619526.16534.8.camel@lade.trondhjem.org> <1128620528.16534.26.camel@lade.trondhjem.org> <1128623899.31797.14.camel@lade.trondhjem.org> <1128626258.31797.34.camel@lade.trondhjem.org> <1128633138.31797.52.camel@lade.trondhjem.org> <1128692289.8519.75.camel@lade.trondhjem.org> Content-Type: text/plain Date: Fri, 07 Oct 2005 11:13:55 -0400 Message-Id: <1128698035.8583.36.camel@lade.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1.1 Content-Transfer-Encoding: 7bit X-UiO-Spam-info: not spam, SpamAssassin (score=-3.891, required 12, autolearn=disabled, AWL 1.11, UIO_MAIL_IS_INTERNAL -5.00) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 32 fr den 07.10.2005 Klokka 15:59 (+0200) skreiv Miklos Szeredi: > You can replace the inode in ->create_open() if you want to. Thinking a bit more clearly after a cup of coffee. This statement isn't even true. Your pseudo-code offers no guarantees that you are the sole user of the dentry once you get to create_open(). > Or let the VFS redo the lookup (as if d_revalidate() returned 0). Which may return yet another result for the dentry and another race. There is no guarantee that you will ever make progress if someone is doing something like. while true do echo "1" > foo echo "2" > foo done on the server. Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/