Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964874AbVJGXea (ORCPT ); Fri, 7 Oct 2005 19:34:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964877AbVJGXea (ORCPT ); Fri, 7 Oct 2005 19:34:30 -0400 Received: from mx1.redhat.com ([66.187.233.31]:39598 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S964874AbVJGXe3 (ORCPT ); Fri, 7 Oct 2005 19:34:29 -0400 From: David Howells In-Reply-To: <20051007220426.GC5856@shell0.pdx.osdl.net> References: <20051007220426.GC5856@shell0.pdx.osdl.net> <19008.1128699684@warthog.cambridge.redhat.com> <11615.1128694058@warthog.cambridge.redhat.com> <26883.1128700665@warthog.cambridge.redhat.com> To: Chris Wright Cc: David Howells , torvalds@osdl.org, akpm@osdl.org, keyrings@linux-nfs.org, linux-kernel@vger.kernel.org Subject: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2] X-Mailer: MH-E 7.84; nmh 1.1; GNU Emacs 22.0.50.1 Date: Sat, 08 Oct 2005 00:34:00 +0100 Message-ID: <12605.1128728040@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 569 Lines: 18 Chris Wright wrote: > > +{ > > + return -1; > > +} > > No solid reason on that one, might as well be 0 for consistency. Grrr! That needs to be zero otherwise it'll deny everything by default. I'd fallen over that one and fixed it, but I must've forgotten to rediff the patch before submitting it. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/