Date: Fri, 7 Oct 2005 16:35:47 -0700
From: Chris Wright <chrisw@osdl.org>
To: David Howells <dhowells@redhat.com>
Cc: Chris Wright <chrisw@osdl.org>, torvalds@osdl.org, akpm@osdl.org,
       keyrings@linux-nfs.org, linux-kernel@vger.kernel.org
Subject: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
Message-ID: <20051007233547.GH5856@shell0.pdx.osdl.net>
References: <20051007220426.GC5856@shell0.pdx.osdl.net> <19008.1128699684@warthog.cambridge.redhat.com> <11615.1128694058@warthog.cambridge.redhat.com> <26883.1128700665@warthog.cambridge.redhat.com> <12605.1128728040@warthog.cambridge.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12605.1128728040@warthog.cambridge.redhat.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 807
Lines: 21

* David Howells (dhowells@redhat.com) wrote:
> Chris Wright <chrisw@osdl.org> wrote:
> 
> > > +{
> > > +	return -1;
> > > +}
> > 
> > No solid reason on that one, might as well be 0 for consistency.
> 
> Grrr! That needs to be zero otherwise it'll deny everything by default. I'd
> fallen over that one and fixed it, but I must've forgotten to rediff the patch
> before submitting it.

I thought that too at first, which is why I flagged it at first.  But I
think it's actually not a real problem, because isn't that !CONFIG_KEYS?
So, I think it's just cosmetic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/