Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751093AbVJJRuQ (ORCPT ); Mon, 10 Oct 2005 13:50:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751094AbVJJRuQ (ORCPT ); Mon, 10 Oct 2005 13:50:16 -0400 Received: from pop.gmx.de ([213.165.64.20]:58516 "HELO mail.gmx.net") by vger.kernel.org with SMTP id S1751093AbVJJRuO (ORCPT ); Mon, 10 Oct 2005 13:50:14 -0400 X-Authenticated: #20450766 Date: Mon, 10 Oct 2005 19:48:12 +0200 (CEST) From: Guennadi Liakhovetski To: Peter Osterlund cc: linux-kernel@vger.kernel.org, Jens Axboe Subject: Re: [2.6.13] pktcdvd: IO-errors In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 46 On Sun, 9 Oct 2005, Peter Osterlund wrote: > Guennadi Liakhovetski writes: > > > On Sun, 2 Oct 2005, Peter Osterlund wrote: > > > > > OK, in that case this patch for 2.6.12 should work as well, because > > > all it does compared to the previous patch is to remove the now unused > > > high_prio_read variables. Can you confirm that it works? > > > > Yes, it does. > > In that case, this patch should also work. Does it? Yes. 2.6.13 + this patch work for me. Thanks Guennadi > > diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c > index d4b9c17..cb6bda9 100644 > --- a/drivers/block/pktcdvd.c > +++ b/drivers/block/pktcdvd.c > @@ -538,7 +538,7 @@ static void pkt_iosched_process_queue(st > spin_unlock(&pd->iosched.lock); > if (bio && (bio->bi_sector == pd->iosched.last_write)) > need_write_seek = 0; > - if (need_write_seek && reads_queued) { > + if (!writes_queued && reads_queued) { > if (atomic_read(&pd->cdrw.pending_bios) > 0) { > VPRINTK("pktcdvd: write, waiting\n"); > break; > > -- > Peter Osterlund - petero2@telia.com > http://web.telia.com/~u89404340 > --- Guennadi Liakhovetski - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/