Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751190AbVJJUDS (ORCPT ); Mon, 10 Oct 2005 16:03:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751192AbVJJUDS (ORCPT ); Mon, 10 Oct 2005 16:03:18 -0400 Received: from mx1.rowland.org ([192.131.102.7]:11282 "HELO mx1.rowland.org") by vger.kernel.org with SMTP id S1751190AbVJJUDR (ORCPT ); Mon, 10 Oct 2005 16:03:17 -0400 Date: Mon, 10 Oct 2005 16:03:13 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Harald Welte cc: Linus Torvalds , Chris Wright , Sergey Vlasov , , , , Subject: Re: [linux-usb-devel] Re: [BUG/PATCH/RFC] Oops while completing async USB via usbdevio In-Reply-To: <20051010174429.GH5627@rama> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 18 On Mon, 10 Oct 2005, Harald Welte wrote: > + if ((!info || ((unsigned long)info != 1 && > + (unsigned long)info != 2 && SI_FROMUSER(info))) > + && (euid ^ p->suid) && (euid ^ p->uid) > + && (uid ^ p->suid) && (uid ^ p->uid)) { No doubt this was copied from somewhere else. But why do people go to the effort of confusing readers by using "^" instead of "!="? These aren't bit-oriented values. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/