Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbVJKRtf (ORCPT ); Tue, 11 Oct 2005 13:49:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751466AbVJKRtf (ORCPT ); Tue, 11 Oct 2005 13:49:35 -0400 Received: from witte.sonytel.be ([80.88.33.193]:46987 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S1751462AbVJKRte (ORCPT ); Tue, 11 Oct 2005 13:49:34 -0400 Date: Tue, 11 Oct 2005 19:49:19 +0200 (CEST) From: Geert Uytterhoeven To: Hareesh Nagarajan cc: Linux Kernel Development , davem@redhat.com Subject: Re: [PATCH] Trivial patch to remove list member from struct tcx_par in drivers/video/tcx.c In-Reply-To: <434B23CB.7000609@gmail.com> Message-ID: References: <434B23CB.7000609@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2486 Lines: 78 On Mon, 10 Oct 2005, Hareesh Nagarajan wrote: > This patch removes the list_head member 'list' from struct tcx_par in the file > drivers/video/tcx.c among other trivial cleanups. The member 'list' is never > used. It turns out that other frame buffer code like cg14.c, leo.c, bw2.c, > etc. (in drivers/video) seem to have the same extra list_head member in their > respective *_par structures. What about the other changes you made (cfr. below)? > The patch applies to the 2.6.13.4 kernel sources. Please send patches inlined in the future. If you send them as an attachment, we cannot easily comment on them. > (AFAICT, I am not missing anything; If I am, I'm sorry for wasting your time.) > --- linux-2.6.13.4/drivers/video/tcx.c 2005-10-10 13:54:29.000000000 -0500 > +++ linux-2.6.13.4-edit/drivers/video/tcx.c 2005-10-10 21:05:22.110156000 -0500 > @@ -174,13 +173,13 @@ > unsigned red, unsigned green, unsigned blue, > unsigned transp, struct fb_info *info) > { > + if (regno >= 256) > + return 1; > + > struct tcx_par *par = (struct tcx_par *) info->par; > struct bt_regs __iomem *bt = par->bt; > unsigned long flags; > > - if (regno >= 256) > - return 1; > - > red >>= 8; > green >>= 8; > blue >>= 8; Please don't change this, or it won't compile anymore with gcc 2.95. > @@ -442,7 +441,7 @@ > > tcx_reset(&all->info); > > - tcx_blank(0, &all->info); > + tcx_blank(FB_BLANK_UNBLANK, &all->info); > > if (fb_alloc_cmap(&all->info.cmap, 256, 0)) { > printk(KERN_ERR "tcx: Could not allocate color map.\n"); What about this change? > @@ -490,8 +489,7 @@ > struct list_head *pos, *tmp; > > list_for_each_safe(pos, tmp, &tcx_list) { > - struct all_info *all = list_entry(pos, typeof(*all), list); > - > + struct all_info *all = list_entry(pos, struct all_info, list); > unregister_framebuffer(&all->info); > fb_dealloc_cmap(&all->info.cmap); > kfree(all); And this one? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/