From: Andi Kleen <ak@suse.de>
To: Alon Bar-Lev <alon.barlev@gmail.com>
Subject: Re: [PATCH 1/1] 2.6.14-rc3 x86: COMMAND_LINE_SIZE
Date: Tue, 11 Oct 2005 22:21:05 +0200
User-Agent: KMail/1.8
Cc: linux-kernel@vger.kernel.org, Georg Lippold <georg.lippold@gmx.de>
References: <431628D5.1040709@zytor.com> <p73br1vsvup.fsf@verdi.suse.de> <434C1189.4090207@gmail.com>
In-Reply-To: <434C1189.4090207@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200510112221.05789.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1117
Lines: 26

On Tuesday 11 October 2005 21:24, Alon Bar-Lev wrote:

> I don't understand this dependency. The cmd_line_ptr is a
> null terminated string which set by the boot loader.

Yes and limited by it and the boot protocol. And changing that CONFIG
wont' change that. IMHO this config is highly misleading.

> I think that the maximum size should be set to 1024, but
> since the kernel allocates a static buffer, users may wish
> to optimize it. So I think that a configuration option is
> the right place.

It's a bad idea to have a CONFIG for every buffer. If we go down this way
this way we end up with a unconfigurable kernel at some point with
hundreds of obscure parameters. Just increase it if there is a need for it.
If you're really worried about memory consumption you can
make the big buffer __initdata and copy it to a newly allocated buffer of the 
right size.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/