Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932431AbVJLMTt (ORCPT ); Wed, 12 Oct 2005 08:19:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932432AbVJLMTt (ORCPT ); Wed, 12 Oct 2005 08:19:49 -0400 Received: from holly.csn.ul.ie ([136.201.105.4]:31398 "EHLO holly.csn.ul.ie") by vger.kernel.org with ESMTP id S932431AbVJLMTs (ORCPT ); Wed, 12 Oct 2005 08:19:48 -0400 Date: Wed, 12 Oct 2005 13:19:37 +0100 (IST) From: Mel Gorman X-X-Sender: mel@skynet To: Dave Hansen Cc: Andrew Morton , jschopp@austin.ibm.com, kravetz@us.ibm.com, Linux Kernel Mailing List , linux-mm , lhms Subject: Re: [Lhms-devel] [PATCH 8/8] Fragmentation Avoidance V17: 008_stats In-Reply-To: <1129118247.6134.54.camel@localhost> Message-ID: References: <20051011151221.16178.67130.sendpatchset@skynet.csn.ul.ie> <20051011151302.16178.46089.sendpatchset@skynet.csn.ul.ie> <1129118247.6134.54.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 35 On Wed, 12 Oct 2005, Dave Hansen wrote: > On Tue, 2005-10-11 at 16:13 +0100, Mel Gorman wrote: > > +#ifdef CONFIG_ALLOCSTAT > > + memset((unsigned long *)zone->fallback_count, 0, > > + sizeof(zone->fallback_count)); > > + memset((unsigned long *)zone->alloc_count, 0, > > + sizeof(zone->alloc_count)); > > + memset((unsigned long *)zone->alloc_count, 0, > > + sizeof(zone->alloc_count)); > > + zone->kernnorclm_partial_steal=0; > > + zone->kernnorclm_full_steal=0; > > + zone->reserve_count[RCLM_NORCLM] = > > + realsize >> (MAX_ORDER-1); > > +#endif > > The struct zone is part of the pgdat which is zeroed at boot-time on all > architectures and configuration that I have ever audited. Re-zeroing > parts of it here is unnecessary. > > BTW, that '=0' with no spaces is anti-CodingStyle. > Blast, true. However, the whole block of code can be simply removed which I prefer. I didn't like the #ifdef in the middle of the function. -- Mel Gorman Part-time Phd Student Java Applications Developer University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/