Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751007AbVJMMjJ (ORCPT ); Thu, 13 Oct 2005 08:39:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751307AbVJMMjI (ORCPT ); Thu, 13 Oct 2005 08:39:08 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:60349 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751007AbVJMMjH (ORCPT ); Thu, 13 Oct 2005 08:39:07 -0400 Message-ID: <434E5574.8060901@de.ibm.com> Date: Thu, 13 Oct 2005 14:39:16 +0200 From: Carsten Otte Reply-To: carsteno@de.ibm.com Organization: IBM Deutschland User-Agent: Debian Thunderbird 1.0.2 (X11/20050602) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Hugh Dickins CC: Andrew Morton , Nick Piggin , linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/21] mm: xip_unmap ZERO_PAGE fix References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 616 Lines: 15 Hugh Dickins wrote: > Small fix to the PageReserved patch: the mips ZERO_PAGE(address) depends > on address, so __xip_unmap is wrong to initialize page with that before > address is initialized; and in fact must re-evaluate it each iteration. Looks fine to me. I never realized they have multiple zero pages on mips. -- Carsten Otte IBM Linux technology center ARCH=s390 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/