Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932432AbVJMUDc (ORCPT ); Thu, 13 Oct 2005 16:03:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932392AbVJMUDb (ORCPT ); Thu, 13 Oct 2005 16:03:31 -0400 Received: from fmr13.intel.com ([192.55.52.67]:21377 "EHLO fmsfmr001.fm.intel.com") by vger.kernel.org with ESMTP id S932438AbVJMUDa convert rfc822-to-8bit (ORCPT ); Thu, 13 Oct 2005 16:03:30 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers Date: Thu, 13 Oct 2005 16:03:17 -0400 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers Thread-Index: AcXQK/UAxrciNJdkRrac1/3GPORGIAABCqOA From: "Brown, Len" To: "Jesper Juhl" , "linux-kernel" Cc: "Andrew Morton" , , "Jakub Jelinek" , "Frodo Looijaard" , "Jean Delvare" , "Bartlomiej Zolnierkiewicz" , "Jens Axboe" , "Roland Dreier" , "Sergio Rozanski Filho" , "Benjamin Herrenschmidt" , "Pierre Ossman" , "Carsten Gross" , "Greg Kroah-Hartman" , "David Hinds" , "Vinh Truong" , "Mark Douglas Corner" , "Michael Downey" , "Antonino Daplas" , "Ben Gardner" X-OriginalArrivalTime: 13 Oct 2005 20:01:26.0829 (UTC) FILETIME=[E4F66DD0:01C5D030] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 32 Re: ACPI files Acked-by: Len Brown thanks, -Len ps. I'm okay with reducing the routine below to a 2-liner if you're so inclined. >--- linux-2.6.14-rc4-orig/drivers/acpi/container.c >2005-10-11 22:41:04.000000000 +0200 >+++ linux-2.6.14-rc4/drivers/acpi/container.c 2005-10-12 >16:31:11.000000000 +0200 >@@ -118,11 +118,9 @@ static int acpi_container_remove(struct > { > acpi_status status = AE_OK; > struct acpi_container *pc = NULL; >- pc = (struct acpi_container *)acpi_driver_data(device); >- >- if (pc) >- kfree(pc); > >+ pc = (struct acpi_container *)acpi_driver_data(device); >+ kfree(pc); > return status; > } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/