Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751203AbVJNEeD (ORCPT ); Fri, 14 Oct 2005 00:34:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751278AbVJNEeD (ORCPT ); Fri, 14 Oct 2005 00:34:03 -0400 Received: from willy.net1.nerim.net ([62.212.114.60]:56583 "EHLO willy.net1.nerim.net") by vger.kernel.org with ESMTP id S1751203AbVJNEeB (ORCPT ); Fri, 14 Oct 2005 00:34:01 -0400 Date: Fri, 14 Oct 2005 06:32:34 +0200 From: Willy Tarreau To: Nick Warne Cc: linux-kernel@vger.kernel.org, marcelo.tosatti@cyclades.com Subject: Re: [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option Message-ID: <20051014043234.GJ22601@alpha.home.local> References: <200510131838.45082.nick@linicks.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510131838.45082.nick@linicks.net> User-Agent: Mutt/1.5.10i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 29 Hi Nick, On Thu, Oct 13, 2005 at 06:38:44PM +0100, Nick Warne wrote: (...) > diff -Naur linux-2.4.31.orig/arch/i386/kernel/dmi_scan.c > linux-2.4.31n/arch/i386/kernel/dmi_scan.c > --- linux-2.4.31.orig/arch/i386/kernel/dmi_scan.c Wed Nov 17 11:54:21 2004 > +++ linux-2.4.31n/arch/i386/kernel/dmi_scan.c Wed Oct 12 15:57:27 2005 > @@ -412,11 +412,13 @@ > static __init int broken_ps2_resume(struct dmi_blacklist *d) > { > #ifdef CONFIG_VT > +#ifndef CONFIG_DUMMY_KEYB Please could you change this to #if defined(CONFIG_VT) && !defined(CONFIG_DUMMY_KEYB) ? Marcelo, I'd like this one to be merged, as it is useful to many of us, and is already fixed in 2.6 (where you're not forced to have a keyboard). It's not intrusive and at most a build fix. Would you please accept Nick's patch after the little clean-up above ? Thanks in advance, Willy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/