Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750707AbVJNKAn (ORCPT ); Fri, 14 Oct 2005 06:00:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750704AbVJNKAm (ORCPT ); Fri, 14 Oct 2005 06:00:42 -0400 Received: from coyote.holtmann.net ([217.160.111.169]:14315 "EHLO mail.holtmann.net") by vger.kernel.org with ESMTP id S1750703AbVJNKAl (ORCPT ); Fri, 14 Oct 2005 06:00:41 -0400 Subject: Re: [PATCH 01/14] Big kfree NULL check cleanup - net From: Marcel Holtmann To: Jesper Juhl Cc: linux-kernel , Andrew Morton , netdev@vger.kernel.org, "David S. Miller" , Hideaki YOSHIFUJI , Arnaldo Carvalho de Melo , Ralf Baechle , Greg Kroah-Hartman , dccp@vger.kernel.org, Patrick Caulfield , Jean Tourrilhes , Sridhar Samudrala , Andy Adamson , "J. Bruce Fields" , Nenad Corbic , Alexey Kuznetsov In-Reply-To: <200510132125.44470.jesper.juhl@gmail.com> References: <200510132125.44470.jesper.juhl@gmail.com> Content-Type: text/plain Date: Fri, 14 Oct 2005 11:50:50 +0200 Message-Id: <1129283450.5057.29.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 38 Hi Jesper, > This is the net/ part of the big kfree cleanup patch. > > Remove pointless checks for NULL prior to calling kfree() in net/. > > > Sorry about the long Cc: list, but I wanted to make sure I included everyone > who's code I've changed with this patch. you forgot me ;) > --- linux-2.6.14-rc4-orig/net/bluetooth/hidp/core.c 2005-08-29 01:41:01.000000000 +0200 > +++ linux-2.6.14-rc4/net/bluetooth/hidp/core.c 2005-10-13 11:47:49.000000000 +0200 > @@ -657,9 +657,7 @@ unlink: > failed: > up_write(&hidp_session_sem); > > - if (session->input) > - kfree(session->input); > - > + kfree(session->input); > kfree(session); > return err; > } Signed-off-by: Marcel Holtmann Regards Marcel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/