Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750749AbVJNNh1 (ORCPT ); Fri, 14 Oct 2005 09:37:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750750AbVJNNh1 (ORCPT ); Fri, 14 Oct 2005 09:37:27 -0400 Received: from 22.107.233.220.exetel.com.au ([220.233.107.22]:4878 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S1750749AbVJNNh1 (ORCPT ); Fri, 14 Oct 2005 09:37:27 -0400 From: Herbert Xu To: suzannew@cs.pdx.edu (Suzanne Wood) Subject: Re: [RFC][PATCH] rcu in drivers/net/hamradio Cc: linux-kernel@vger.kernel.org, g4klx@g4klx.demon.co.uk, hch@infradead.org, jreuter@yaina.de, paulmck@us.ibm.com, suzannew@cs.pdx.edu, walpole@cs.pdx.edu Organization: Core In-Reply-To: <200510140804.j9E84nwG026920@rastaban.cs.pdx.edu> X-Newsgroups: apana.lists.os.linux.kernel User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) Message-Id: Date: Fri, 14 Oct 2005 23:37:01 +1000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 25 Suzanne Wood wrote: > > (1) bpq_new_device() calls list_add_rcu() labeled as > "list protected by RTNL." The comment may need to go > since the only apparent rtnl_lock()/unlock() pair encloses > the call to bpq_free_device() in bpq_cleanup_driver() > called upon module_exit(). The RTNL comment is correct actually. bpq_new_device can only be called from bpq_device_event which is called from a netdev event handler. All netdev event handlers must be called uner the RTNL. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/