From: Wilson Michaels <wilsonmichaels@earthlink.net>
To: Jesper Juhl <jesper.juhl@gmail.com>
Subject: Re: [PATCH 08/14] Big kfree NULL check cleanup - drivers/media
Date: Fri, 14 Oct 2005 22:21:06 -0500
User-Agent: KMail/1.8.1
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@osdl.org>, Manu Abraham <manu@kromtek.com>,
       Emard <emard@softhome.net>, Marko Kohtala <marko.kohtala@luukku.com>,
       Andreas Oberritter <obi@linuxtv.org>,
       Kirk Lapray <kirk_lapray@bigfoot.com>,
       Mauro Carvalho Chehab <mchehab@brturbo.com.br>,
       Takeo Takahashi <takahashi.takeo@renesas.com>,
       Ralph Metzler <rjkm@thp.uni-koeln.de>, Gerd Knorr <kraxel@bytesex.org>,
       Bill Dirks <bdirks@pacbell.net>, Wolfgang Scherr <scherr@net4you.at>,
       Alan Cox <alan@redhat.com>, Ronald Bultje <rbultje@ronald.bitfreak.net>,
       Serguei Miridonov <mirsev@cicese.mx>
References: <200510132128.12616.jesper.juhl@gmail.com>
In-Reply-To: <200510132128.12616.jesper.juhl@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200510142221.07341.wilsonmichaels@earthlink.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1268
Lines: 43

On Thursday 13 October 2005 02:28 pm, Jesper Juhl wrote:
> This is the drivers/media/ part of the big kfree cleanup
> patch.
>
> Remove pointless checks for NULL prior to calling kfree()
> in drivers/media/.
>
>
> Sorry about the long Cc: list, but I wanted to make sure
> I included everyone who's code I've changed with this
> patch.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
>
> Please see the initial announcement mail on LKML with
> subject "[PATCH 00/14] Big kfree NULL check cleanup"
> for additional details.
>

> linux-2.6.14-rc4-orig/drivers/media/dvb/frontends/lgdt330
>x.c	2005-10-11 22:41:09.000000000 +0200 +++
> linux-2.6.14-rc4/drivers/media/dvb/frontends/lgdt330x.c	2
>005-10-13 10:28:41.000000000 +0200 @@ -729,8 +729,7 @@
> struct dvb_frontend* lgdt330x_attach(con return
> &state->frontend;
>
>  error:
> -	if (state)
> -		kfree(state);
> +	kfree(state);
>  	dprintk("%s: ERROR\n",__FUNCTION__);
>  	return NULL;
>  }
> ---

Acked-by : Wilson Michaels <wilsonmichaels@earthlink.net>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/