Date: Sun, 16 Oct 2005 00:48:23 +0200
From: Mattia Dongili <malattia@linux.it>
To: emard@softhome.net, linux-kernel@vger.kernel.org
Subject: Re: uinput crash and fix
Message-ID: <20051015224822.GH3564@inferi.kami.home>
Mail-Followup-To: emard@softhome.net, linux-kernel@vger.kernel.org
References: <20051015212911.GA25752@tink> <20051015220115.GG3564@inferi.kami.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051015220115.GG3564@inferi.kami.home>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 27

On Sun, Oct 16, 2005 at 12:01:15AM +0200, Mattia Dongili wrote:
> On Sat, Oct 15, 2005 at 11:29:12PM +0200, emard@softhome.net wrote:
> > HI
> [...]
> >  			req = uinput_request_find(udev, ff_up.request_id);
> > -			if (!(req && req->code == UI_FF_UPLOAD && req->u.effect)) {
> > +			if (!req) {
> 
> out of curiosity, instead of adding a whole if block wouldn't be easier
> to just write 
> 
> 	if (!req || !(req->code == UI_FF_UPLOAD && req->u.effect)) {
> 
> in order to evaulate !req first and eventually dereference it?

hmmm... no. it's simply the same ( (A && B) == (!A || !B)). So your
patch seems wrong too.

goodnight :P
-- 
mattia
:wq!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/