Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbVJPUbn (ORCPT ); Sun, 16 Oct 2005 16:31:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751304AbVJPUbn (ORCPT ); Sun, 16 Oct 2005 16:31:43 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:29455 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1751301AbVJPUbm (ORCPT ); Sun, 16 Oct 2005 16:31:42 -0400 Date: Sun, 16 Oct 2005 21:31:36 +0100 From: Russell King To: Linux Kernel List , Andrew Morton , Greg KH Subject: [PATCH 1/2] Fixup PCI driver shutdown Message-ID: <20051016203135.GD14413@flint.arm.linux.org.uk> Mail-Followup-To: Linux Kernel List , Andrew Morton , Greg KH Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 29 Add a warning to pci driver registration code so that we know whether we have drivers using the obsolete driver shutdown method. Signed-off-by: Russell King diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -377,6 +377,9 @@ int pci_register_driver(struct pci_drive * the pci shutdown function, this test can go away. */ if (!drv->driver.shutdown) drv->driver.shutdown = pci_device_shutdown; + else + printk(KERN_WARNING "Warning: PCI driver %s has a struct device_driver shutdown method, please update!\n", + drv->name); drv->driver.owner = drv->owner; drv->driver.kobj.ktype = &pci_driver_kobj_type; -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/