Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbVJQP4g (ORCPT ); Mon, 17 Oct 2005 11:56:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751410AbVJQP4g (ORCPT ); Mon, 17 Oct 2005 11:56:36 -0400 Received: from mx3.actcom.co.il ([192.114.47.65]:26272 "EHLO smtp3.actcom.co.il") by vger.kernel.org with ESMTP id S1751408AbVJQP4f (ORCPT ); Mon, 17 Oct 2005 11:56:35 -0400 Date: Mon, 17 Oct 2005 17:56:13 +0200 From: Muli Ben-Yehuda To: Andi Kleen Cc: Linus Torvalds , Andrew Morton , Ravikiran G Thirumalai , linux-kernel@vger.kernel.org, discuss@x86-64.org, tglx@linutronix.de, shai@scalex86.org Subject: Re: x86_64: 2.6.14-rc4 swiotlb broken Message-ID: <20051017155613.GF21783@granada.merseine.nu> References: <20051017093654.GA7652@localhost.localdomain> <200510171153.56063.ak@suse.de> <200510171740.57614.ak@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171740.57614.ak@suse.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 32 On Mon, Oct 17, 2005 at 05:40:56PM +0200, Andi Kleen wrote: > First this problem is definitely not critical. AFAIK it only happens on > scalex's unreleased machines. Intel NUMA x86 machines are really rare > and on AMD it doesn't happen because the swiotlb is not used there. It's not used by default, but there are cases where it's used and it would be a shame to release a major kernel and knowingly break them. For example, any setup that used iommu_force or any non-AMD x86-64 machine with more than 4GB of memory and only 32-bit capable DMA devices. > Both NODE(0) and node_online_map are risky. NODE(0) may break IA64 > (they share this code) and node_online_map may break one of the weirder > ARM platforms again (for which the original revert was done) I don't have an IA64 machine, but if the NODE(0) fix is safe there, I vote for it for 2.6.14-rc4. Another alternative is to temporarily provide a different version of swiotlb_init() for x86-64 and IA64 - I can whip up a patch if that's acceptable. Cheers, Muli -- Muli Ben-Yehuda http://www.mulix.org | http://mulix.livejournal.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/