Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932070AbVJRATj (ORCPT ); Mon, 17 Oct 2005 20:19:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751427AbVJRATj (ORCPT ); Mon, 17 Oct 2005 20:19:39 -0400 Received: from gateway-1237.mvista.com ([12.44.186.158]:25846 "EHLO godzilla.mvista.com") by vger.kernel.org with ESMTP id S1751425AbVJRATi (ORCPT ); Mon, 17 Oct 2005 20:19:38 -0400 Date: Mon, 17 Oct 2005 17:19:34 -0700 (PDT) From: Daniel Walker To: Ingo Molnar cc: linux-kernel@vger.kernel.org, Thomas Gleixner , david singleton , Steven Rostedt , Rui Nuno Capela , Fernando Lopez-Lezcano , Mark Knecht Subject: Re: 2.6.14-rc4-rt7 In-Reply-To: <20051017160536.GA2107@elte.hu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 30 The clocksource_lock should be a raw because it's locked with the raw lock system_time_lock held, and interrupts are off . So it could sleep with interrupts disabled. I just compile tested this, but I think it should be fine . Daniel Index: linux-2.6.13/kernel/time/clocksource.c =================================================================== --- linux-2.6.13.orig/kernel/time/clocksource.c +++ linux-2.6.13/kernel/time/clocksource.c @@ -46,7 +46,7 @@ extern struct clocksource clocksource_ji static struct clocksource *curr_clocksource = &clocksource_jiffies; static struct clocksource *next_clocksource; static LIST_HEAD(clocksource_list); -static DECLARE_SEQLOCK(clocksource_lock); +static DECLARE_RAW_SEQLOCK(clocksource_lock); static char override_name[32]; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/