Date: Mon, 17 Oct 2005 20:31:37 -0700
From: Andrew Morton <akpm@osdl.org>
To: WU Fengguang <wfg@mail.ustc.edu.cn>
Cc: joern@wohnheim.fh-wedel.de, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH] Adaptive read-ahead v4
Message-Id: <20051017203137.05350739.akpm@osdl.org>
In-Reply-To: <20051018025806.GA3963@mail.ustc.edu.cn>
References: <20051015174731.GA5851@mail.ustc.edu.cn>
	<20051017173034.GA6558@wohnheim.fh-wedel.de>
	<20051018025806.GA3963@mail.ustc.edu.cn>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1268
Lines: 35

WU Fengguang <wfg@mail.ustc.edu.cn> wrote:
>
> ...
> > > +	unsigned long pgra_backward;
> > > +	unsigned long pgra_backward_hit;
> > > +	unsigned long pgra_backward_eof;
> > > +
> > > +	unsigned long ra_random;	/* read-ahead on seek-and-read-pages */
> > > +	unsigned long ra_random_return;
> > > +	unsigned long ra_random_eof;
> > > +	unsigned long pgra_random;
> > > +	unsigned long pgra_random_hit;
> > > +	unsigned long pgra_random_eof;
> > > +
> > >  };
> > 
> > Without actually understanding what you're doing, wouldn't a struct
> > for all those groups make sense?  I bet it can simplify the actual
> > code as well.
> Yeah, I did not expect the structure to grow so large.

All that stuff shouldn't remain there long-term.

> It should be better to create a stand alone struct and create a
> dedicated entry in /proc/. The data would be a nice hint for
> administrators who care the performance.

You should treat such informaton as a development aid, really.  People are
very unlikely to look at it in real life.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/