Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750705AbVJRNCJ (ORCPT ); Tue, 18 Oct 2005 09:02:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750716AbVJRNCI (ORCPT ); Tue, 18 Oct 2005 09:02:08 -0400 Received: from hera.kernel.org ([140.211.167.34]:905 "EHLO hera.kernel.org") by vger.kernel.org with ESMTP id S1750705AbVJRNCI (ORCPT ); Tue, 18 Oct 2005 09:02:08 -0400 Date: Tue, 18 Oct 2005 06:02:26 -0200 From: Marcelo Tosatti To: Nick Warne Cc: linux-kernel@vger.kernel.org, Willy Tarreau Subject: Re: [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option Message-ID: <20051018080226.GB13299@logos.cnet> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 26 On Fri, Oct 14, 2005 at 10:19:44AM +0100, Nick Warne wrote: > > >> #ifdef CONFIG_VT > >> +#ifndef CONFIG_DUMMY_KEYB > > > Please could you change this to #if defined(CONFIG_VT) && > > !defined(CONFIG_DUMMY_KEYB) ? > > > Marcelo, I'd like this one to be merged, as it is useful to many of us, > > and is already fixed in 2.6 (where you're not forced to have a > > keyboard). It's not intrusive and at most a build fix. Would you please > > accept Nick's patch after the little clean-up above ? > > > OK, the adjusted patch attached. I did look at the ifdefs in that file > for a few minutes; but I see now I should have done it like this in the > first place. Looks fine - Willy can you keep it in your tree and add it later on to the 2.4.33-pre tree? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/