Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750789AbVJSLwX (ORCPT ); Wed, 19 Oct 2005 07:52:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750801AbVJSLwX (ORCPT ); Wed, 19 Oct 2005 07:52:23 -0400 Received: from ms-smtp-02.nyroc.rr.com ([24.24.2.56]:10916 "EHLO ms-smtp-02.nyroc.rr.com") by vger.kernel.org with ESMTP id S1750789AbVJSLwW (ORCPT ); Wed, 19 Oct 2005 07:52:22 -0400 Date: Wed, 19 Oct 2005 07:51:47 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@localhost.localdomain To: Christoph Hellwig cc: Lee Revell , Mark Knecht , linux-kernel@vger.kernel.org, Ingo Molnar , rmk@arm.linux.org.uk, Linus Torvalds , Andrew Morton , andmike@us.ibm.com, linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state. In-Reply-To: <20051019113131.GA30553@infradead.org> Message-ID: References: <5bdc1c8b0510181402o2d9badb0sd18012cf7ff2a329@mail.gmail.com> <1129693423.8910.54.camel@mindpipe> <1129695564.8910.64.camel@mindpipe> <20051019113131.GA30553@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 21 On Wed, 19 Oct 2005, Christoph Hellwig wrote: > > + /* > > + * There's a good chance that the loop will exit in the > > + * TASK_INTERRUPTIBLE state. > > + */ > > + __set_current_state(TASK_RUNNING); > > no need to comment the obvious. > So, should I resend the patch without the comment? -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/