Message-ID: <4356A1F5.5010200@gentoo.org>
Date: Wed, 19 Oct 2005 20:43:49 +0100
From: Daniel Drake <dsd@gentoo.org>
User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051015)
MIME-Version: 1.0
To: Jesse Barnes <jbarnes@virtuousgeek.org>
CC: shemminger@osdl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] skge support for Marvell chips in Toshiba laptops
References: <200510191047.53212.jbarnes@virtuousgeek.org>
In-Reply-To: <200510191047.53212.jbarnes@virtuousgeek.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 27

Hi Jesse,

Jesse Barnes wrote:
> Here's a small patch to add the PCI ID and chip type of the chip in my 
> Toshiba laptop to the skge driver.  I haven't tested it much (just 
> insmoded it and run ethtool against the corresponding eth1 device), but 
> it doesn't crash my system, so unless this configuration has already 
> been tested and is known to have problems, it might be good to add this 
> patch.
> 
> I'll test some more with a real network when I get home.

The device ID you added (0x4351) is already claimed by the new sky2 driver.

Unless theres a mistake in sky2's device table, your laptop contains a 
Yukon-II adapter which is incompatible with the original Yukon chips (skge = 
Yukon, sky2 = Yukon-II).

On the other hand, I believe Stephen could do with some extra sky2 testing :)
You can find it in the latest -mm releases.

Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/