Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751360AbVJSVfi (ORCPT ); Wed, 19 Oct 2005 17:35:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751363AbVJSVfi (ORCPT ); Wed, 19 Oct 2005 17:35:38 -0400 Received: from ams-iport-1.cisco.com ([144.254.224.140]:2330 "EHLO ams-iport-1.cisco.com") by vger.kernel.org with ESMTP id S1751360AbVJSVfh (ORCPT ); Wed, 19 Oct 2005 17:35:37 -0400 To: gcoady@gmail.com Cc: Greg KH , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci_ids: cleanup comments X-Message-Flag: Warning: May contain useful information References: <4eedl1h86sarh1i5g42o7vi21i7v1ece2m@4ax.com> From: Roland Dreier Date: Wed, 19 Oct 2005 14:35:25 -0700 In-Reply-To: <4eedl1h86sarh1i5g42o7vi21i7v1ece2m@4ax.com> (Grant Coady's message of "Thu, 20 Oct 2005 07:27:41 +1000") Message-ID: <524q7di40y.fsf@cisco.com> User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (Jumbo Shrimp, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 X-OriginalArrivalTime: 19 Oct 2005 21:35:26.0493 (UTC) FILETIME=[04F15CD0:01C5D4F5] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 541 Lines: 18 I don't think I like this. I prefer the format #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001 /* PCI-Cbus Bridge */ to taking two lines like /* PCI-Cbus Bridge */ #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001 If some script can't handle the first format then I think the script should be fixed. - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/