Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbVJSVqM (ORCPT ); Wed, 19 Oct 2005 17:46:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751372AbVJSVqM (ORCPT ); Wed, 19 Oct 2005 17:46:12 -0400 Received: from mail.kroah.org ([69.55.234.183]:11745 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S1751370AbVJSVqL (ORCPT ); Wed, 19 Oct 2005 17:46:11 -0400 Date: Wed, 19 Oct 2005 14:45:38 -0700 From: Greg KH To: Roland Dreier Cc: gcoady@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci_ids: cleanup comments Message-ID: <20051019214538.GA6999@kroah.com> References: <4eedl1h86sarh1i5g42o7vi21i7v1ece2m@4ax.com> <524q7di40y.fsf@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <524q7di40y.fsf@cisco.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 24 On Wed, Oct 19, 2005 at 02:35:25PM -0700, Roland Dreier wrote: > I don't think I like this. I prefer the format > > #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001 /* PCI-Cbus Bridge */ > > to taking two lines like > > /* PCI-Cbus Bridge */ > #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001 > > If some script can't handle the first format then I think the script > should be fixed. I agree, comments like this belong on the right hand side, it's cleaner that way. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/