Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964892AbVJUHWK (ORCPT ); Fri, 21 Oct 2005 03:22:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964894AbVJUHWK (ORCPT ); Fri, 21 Oct 2005 03:22:10 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:36553 "EHLO fgwmail6.fujitsu.co.jp") by vger.kernel.org with ESMTP id S964892AbVJUHWJ (ORCPT ); Fri, 21 Oct 2005 03:22:09 -0400 Message-ID: <435896CA.1000101@jp.fujitsu.com> Date: Fri, 21 Oct 2005 16:20:42 +0900 From: KAMEZAWA Hiroyuki User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: ja, en-us, en MIME-Version: 1.0 To: Simon Derr CC: Christoph Lameter , Andrew Morton , Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Magnus Damm , Marcelo Tosatti , Paul Jackson Subject: Re: [PATCH 4/4] Swap migration V3: sys_migrate_pages interface References: <20051020225935.19761.57434.sendpatchset@schroedinger.engr.sgi.com> <20051020225955.19761.53060.sendpatchset@schroedinger.engr.sgi.com> <4358588D.1080307@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 31 > Christoph Lameter wrote: > >>> > + /* Is the user allowed to access the target nodes? */ >>> > + if (!nodes_subset(new, cpuset_mems_allowed(task))) >>> > + return -EPERM; >>> > + > >> How about this ? >> +cpuset_update_task_mems_allowed(task, new); (this isn't implemented now *new* is already guaranteed to be the subset of current mem_allowed. Is this violate the permission ? Simon Derr wrote: > Automatically updating the ->mems_allowed field as you suggest would > require that the kernel do the same checks in sys_migrage_pages(). Sounds > not as a very good idea to me. Hmm, it means a user or admin should modify mem_allowed before the first page fault after calling sys_migrate_pages(). -- Kame - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/