Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751219AbVJVFrv@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751219AbVJVFrv (ORCPT <rfc822;willy@w.ods.org>);
	Sat, 22 Oct 2005 01:47:51 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751287AbVJVFrv
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 22 Oct 2005 01:47:51 -0400
Received: from hera.kernel.org ([140.211.167.34]:45194 "EHLO hera.kernel.org")
	by vger.kernel.org with ESMTP id S1751219AbVJVFru (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 22 Oct 2005 01:47:50 -0400
Date: Fri, 21 Oct 2005 23:06:21 -0200
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, Mike Kravetz <kravetz@us.ibm.com>,
       linux-kernel@vger.kernel.org, linux-mm@kvack.org,
       Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 2/4] Swap migration V3: Page Eviction
Message-ID: <20051022010621.GC27317@logos.cnet>
References: <20051020225935.19761.57434.sendpatchset@schroedinger.engr.sgi.com> <20051020225945.19761.15772.sendpatchset@schroedinger.engr.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051020225945.19761.15772.sendpatchset@schroedinger.engr.sgi.com>
User-Agent: Mutt/1.5.5.1i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 4060
Lines: 146


Hi Christoph,

On Thu, Oct 20, 2005 at 03:59:45PM -0700, Christoph Lameter wrote:
> Page eviction support in vmscan.c
> 
> This patch adds functions that allow the eviction of pages to swap space.
> Page eviction may be useful to migrate pages, to suspend programs or for
> ummapping single pages (useful for faulty pages or pages with soft ECC
> failures)

<snip>

You might want to add some throttling in swapout_pages() instead of 
relying on the block layer to do it for you.

There have been problems before with very large disk queues (IIRC it was
CFQ) in which all available memory became pinned by dirty data causing
OOM.

See throttle_vm_writeout() in mm/vmscan.c. 

> + * Swapout evicts the pages on the list to swap space.
> + * This is essentially a dumbed down version of shrink_list
> + *
> + * returns the number of pages that were not evictable
> + *
> + * Multiple passes are performed over the list. The first
> + * pass avoids waiting on locks and triggers writeout
> + * actions. Later passes begin to wait on locks in order
> + * to have a better chance of acquiring the lock.
> + */
> +int swapout_pages(struct list_head *l)
> +{
> +	int retry;
> +	int failed;
> +	int pass = 0;
> +	struct page *page;
> +	struct page *page2;
> +
> +	current->flags |= PF_KSWAPD;
> +
> +redo:
> +	retry = 0;
> +	failed = 0;
> +
> +	list_for_each_entry_safe(page, page2, l, lru) {
> +		struct address_space *mapping;
> +
> +		cond_resched();
> +
> +		/*
> +		 * Skip locked pages during the first two passes to give the
> +		 * functions holding the lock time to release the page. Later we use
> +		 * lock_page to have a higher chance of acquiring the lock.
> +		 */
> +		if (pass > 2)
> +			lock_page(page);
> +		else
> +			if (TestSetPageLocked(page))
> +				goto retry_later;
> +
> +		/*
> +		 * Only wait on writeback if we have already done a pass where
> +		 * we we may have triggered writeouts for lots of pages.
> +		 */
> +		if (pass > 0)
> +			wait_on_page_writeback(page);
> +		else
> +			if (PageWriteback(page))
> +				goto retry_later_locked;
> +
> +#ifdef CONFIG_SWAP
> +		if (PageAnon(page) && !PageSwapCache(page)) {
> +			if (!add_to_swap(page))
> +				goto failed;
> +		}
> +#endif /* CONFIG_SWAP */
> +
> +		mapping = page_mapping(page);
> +		if (page_mapped(page) && mapping)
> +			if (try_to_unmap(page) != SWAP_SUCCESS)
> +				goto retry_later_locked;
> +
> +		if (PageDirty(page)) {
> +			/* Page is dirty, try to write it out here */
> +			switch(pageout(page, mapping)) {
> +			case PAGE_KEEP:
> +			case PAGE_ACTIVATE:
> +				goto retry_later_locked;
> +			case PAGE_SUCCESS:
> +				goto retry_later;
> +			case PAGE_CLEAN:
> +				; /* try to free the page below */
> +			}
> +		}
> +
> +		if (PagePrivate(page)) {
> +			if (!try_to_release_page(page, GFP_KERNEL))
> +				goto retry_later_locked;
> +			if (!mapping && page_count(page) == 1)
> +				goto free_it;
> +		}
> +
> +		if (!remove_mapping(mapping, page))
> +			goto retry_later_locked;       /* truncate got there first */
> +
> +free_it:
> +		/*
> +		 * We may free pages that were taken off the active list
> +		 * by isolate_lru_page. However, free_hot_cold_page will check
> +		 * if the active bit is set. So clear it.
> +		 */
> +		ClearPageActive(page);
> +
> +		list_del(&page->lru);
> +		unlock_page(page);
> +		put_page(page);
> +		continue;
> +
> +failed:
> +		failed++;
> +		unlock_page(page);
> +		continue;
> +
> +retry_later_locked:
> +		unlock_page(page);
> +retry_later:
> +		retry++;
> +	}
> +	if (retry && pass++ < 10)
> +		goto redo;
> +
> +	current->flags &= ~PF_KSWAPD;
> +	return failed + retry;
> +}
> +
> +/*
>   * zone->lru_lock is heavily contended.  Some of the functions that
>   * shrink the lists perform better by taking out a batch of pages
>   * and working on them outside the LRU lock.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/