Date: Sun, 23 Oct 2005 22:13:20 +0100
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Laurent Riffard <laurent.riffard@free.fr>, Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, dmo@osdl.org, mike.miller@hp.com,
       iss_storagedev@hp.com, Jeff Garzik <garzik@pobox.com>
Subject: Re: [patch] drivers/block: updates .owner field of struct pci_driver
Message-ID: <20051023211320.GB19915@flint.arm.linux.org.uk>
Mail-Followup-To: Laurent Riffard <laurent.riffard@free.fr>,
	Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org,
	dmo@osdl.org, mike.miller@hp.com, iss_storagedev@hp.com,
	Jeff Garzik <garzik@pobox.com>
References: <20051023204947.430464000@antares.localdomain> <20051023204956.213142000@antares.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051023204956.213142000@antares.localdomain>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 970
Lines: 25

On Sun, Oct 23, 2005 at 10:49:48PM +0200, Laurent Riffard wrote:
> This patch updates .owner field of struct pci_driver.
> 
> This allows SYSFS to create the symlink from the driver to the
> module which provides it.
> 
> Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>

Wouldn't it be better to eliminate pci_driver's .owner field and
set the generic device driver's owner field directly? (and fix
the PCI code not to overwrite that if pci_driver's .owner field
is NULL for compatibility.)

I ask for the second time recently on linux-kernel.  Is there
*really* any point in duplicating these fields?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/