Date: Sun, 23 Oct 2005 15:29:57 -0700
From: Greg KH <greg@kroah.com>
To: Laurent Riffard <laurent.riffard@free.fr>, linux-kernel@vger.kernel.org,
       dmo@osdl.org, mike.miller@hp.com, iss_storagedev@hp.com,
       Jeff Garzik <garzik@pobox.com>
Subject: Re: [patch] drivers/block: updates .owner field of struct pci_driver
Message-ID: <20051023222956.GA8332@kroah.com>
References: <20051023204947.430464000@antares.localdomain> <20051023204956.213142000@antares.localdomain> <20051023211320.GB19915@flint.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051023211320.GB19915@flint.arm.linux.org.uk>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1075
Lines: 28

On Sun, Oct 23, 2005 at 10:13:20PM +0100, Russell King wrote:
> On Sun, Oct 23, 2005 at 10:49:48PM +0200, Laurent Riffard wrote:
> > This patch updates .owner field of struct pci_driver.
> > 
> > This allows SYSFS to create the symlink from the driver to the
> > module which provides it.
> > 
> > Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
> 
> Wouldn't it be better to eliminate pci_driver's .owner field and
> set the generic device driver's owner field directly? (and fix
> the PCI code not to overwrite that if pci_driver's .owner field
> is NULL for compatibility.)

No there isn't, we should use the struct device .name and .owner fields
instead of the pci drivers's structure.  Then we can just get rid of the
pci driver's fields too.

I just did this for the usb-serial drivers on Friday.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/