Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbVJYEZV (ORCPT ); Tue, 25 Oct 2005 00:25:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751451AbVJYEZV (ORCPT ); Tue, 25 Oct 2005 00:25:21 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:30149 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1751449AbVJYEZV (ORCPT ); Tue, 25 Oct 2005 00:25:21 -0400 Date: Tue, 25 Oct 2005 05:25:19 +0100 From: Al Viro To: Miklos Szeredi Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/8] VFS: per inode statfs (core) Message-ID: <20051025042519.GJ7992@ftp.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 18 On Mon, Oct 24, 2005 at 06:55:19PM +0200, Miklos Szeredi wrote: > This patch adds a statfs method to inode operations. This is invoked > whenever the dentry is available (not called from sys_ustat()) and the > filesystem implements this method. Otherwise the normal > s_op->statfs() will be called. > > This change is backward compatible, but calls to vfs_statfs() should > be changed to vfs_dentry_statfs() whenever possible. What the fuck for? statfs() returns data that by definition should not depend on inode within a filesystem. NAK, and if FUSE needs that for something, it's *badly* misdesigned. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/