Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932606AbVJZJbx (ORCPT ); Wed, 26 Oct 2005 05:31:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932607AbVJZJbx (ORCPT ); Wed, 26 Oct 2005 05:31:53 -0400 Received: from smtp.nedstat.nl ([194.109.98.184]:2511 "HELO smtp.nedstat.nl") by vger.kernel.org with SMTP id S932606AbVJZJbx (ORCPT ); Wed, 26 Oct 2005 05:31:53 -0400 Subject: Re: [PATCH 1/5] Swap Migration V4: LRU operations From: Peter Zijlstra To: Christoph Lameter Cc: akpm@osdl.org, Marcelo Tosatti , Mike Kravetz , Ray Bryant , Lee Schermerhorn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Magnus Damm , Paul Jackson , Dave Hansen , KAMEZAWA Hiroyuki In-Reply-To: <20051025193028.6828.27929.sendpatchset@schroedinger.engr.sgi.com> References: <20051025193023.6828.89649.sendpatchset@schroedinger.engr.sgi.com> <20051025193028.6828.27929.sendpatchset@schroedinger.engr.sgi.com> Content-Type: text/plain Date: Wed, 26 Oct 2005 11:31:23 +0200 Message-Id: <1130319083.17653.37.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 490 Lines: 16 On Tue, 2005-10-25 at 12:30 -0700, Christoph Lameter wrote: > + if (rc == -1) { /* Not possible to isolate */ > + list_del(&page->lru); > + list_add(&page->lru, src); > } Would the usage of list_move() not be simpler? Peter Zijlstra - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/