To: Al Viro <viro@ftp.linux.org.uk>
Cc: Laurent riffard <laurent.riffard@free.fr>, linux-kernel@vger.kernel.org,
       Greg KH <greg@kroah.com>, Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [RFC patch 2/3] remove pci_driver.owner and .name fields
References: <20051026204802.123045000@antares.localdomain>
	<20051026204909.576265000@antares.localdomain>
	<52vezkyoor.fsf@cisco.com> <20051026212127.GU7992@ftp.linux.org.uk>
From: Roland Dreier <rolandd@cisco.com>
Date: Wed, 26 Oct 2005 14:30:59 -0700
In-Reply-To: <20051026212127.GU7992@ftp.linux.org.uk> (Al Viro's message of
 "Wed, 26 Oct 2005 22:21:27 +0100")
Message-ID: <52r7a8ynho.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (Jumbo Shrimp, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 754
Lines: 37

    > It looks stupid in the first place - what's wrong with
    > 		.driver.name = "DAC960",
    > instead of that mess?

Unfortunately I don't think gcc 2.95 accepts that syntax.  For
example the following:

	void foo(void)
	{
		struct {
			struct {
				int y;
			} x;
		} bar = {
			.x.y = 1
		};
	}

gives

	a.c: In function `foo':
	a.c:8: unknown field `y' specified in initializer

when compiled with gcc 2.95.

I guess we could do

	.driver = { .name = "DAC960" },

but that seems silly as well.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/